Fix cupsCheckDestSupported() handling of "job-password" option#5557
Closed
Nikitosh wants to merge 1 commit intoapple:masterfrom
Nikitosh:fix-job-password-supported
Closed
Fix cupsCheckDestSupported() handling of "job-password" option#5557Nikitosh wants to merge 1 commit intoapple:masterfrom Nikitosh:fix-job-password-supported
Nikitosh wants to merge 1 commit intoapple:masterfrom
Nikitosh:fix-job-password-supported
Conversation
Collaborator
|
Hmm, I think we want to make this more general. Investigating. |
michaelrsweet
added a commit
that referenced
this pull request
Apr 15, 2019
michaelrsweet
added a commit
that referenced
this pull request
Apr 15, 2019
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUPS doesn't handle correctly "job-password" option in cupsCheckDestSupported() function, since it expects the integer value when IPP tag of "X-supported" attribute is IPP_TAG_INTEGER, but in case of "job-password" we have string value.
This commit adds separate check for that and fixes it.